Skip to content

feat: add React Router and restructure project #11

Jump to bottom
Merged
merged 12 commits into from
Sep 30, 2026
Merged

feat: add React Router and restructure project #11

merged 12 commits into from
Sep 30, 2026
+1,265 −466

Conversation

martakam
Copy link
Member

@martakam martakam commented Sep 29, 2026 •
edited
Loading

This PR restructures the project to use React Router, in order to allow us to create a proper multi-page app

Another PR will be created which takes advantage of this, while this PR focuses on adding React Router in general.

@martakam martakam marked this pull request as ready for review September 30, 2026 18:07
@martakam martakam requested a review from a team as a code owner September 30, 2026 18:07
@martakam martakam self-assigned this Sep 30, 2026
@martakam martakam added the enhancement New feature or request label Sep 30, 2026
@martakam martakam linked an issue Sep 30, 2026 that may be closed by this pull request
feat: add React Router #2
Closed
@martakam
Copy link
Member Author

This PR is now ready for review. This is a big PR which changes a lot of the files, moves them around and so on. Feel free to ask questions about any of the changes.

@hestro
Copy link
Member

hestro commented Sep 30, 2026

This PR is now ready for review. This is a big PR which changes a lot of the files, moves them around and so on. Feel free to ask questions about any of the changes.

Just to make sure I understand the restructuring: is App.tsx essentially replaced by home.tsx (with this being the only route for now), while main.tsx and index.html are essentially handled by root.tsx?

hestro
hestro approved these changes Sep 30, 2026
View reviewed changes
Copy link
Member

@hestro hestro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm starting to get the new folder structure.
I also like the new error handling and the loading message.

The changes look good, and the app runs well, so approving!

@martakam martakam mentioned this pull request Sep 30, 2026
Merged
@martakam
Copy link
Member Author

This PR is now ready for review. This is a big PR which changes a lot of the files, moves them around and so on. Feel free to ask questions about any of the changes.

Just to make sure I understand the restructuring: is App.tsx essentially replaced by home.tsx (with this being the only route for now), while main.tsx and index.html are essentially handled by root.tsx?

Exactly! The default React Router template could be useful to take a look at, and it shows that it replaces the index.html completely and root.tsx takes over that role.

Furthermore, the index page (/) is home.tsx, as you said.

@martakam
Copy link
Member Author

Another thing worth mentioning: Our default import alias for the project is now ~/, while we didn't have anything set up before, so we needed to use relative paths like ../../components/.... Now, this would be ~/components/... instead

@martakam martakam merged commit 8a82c4a into main Sep 30, 2026
@martakam martakam changed the title feat: Add React Router and restructure project feat: add React Router and restructure project Oct 1, 2026
@martakam martakam added this to the Deliverable 1 milestone Oct 2, 2026
@martakam martakam deleted the feat/react-router branch October 3, 2026 19:53
Sign in to join this conversation on GitHub.
Reviewers

@hestro hestro hestro approved these changes

Assignees

@martakam martakam

Labels
enhancement New feature or request
Projects
None yet
Milestone
Deliverable 1
Development

Successfully merging this pull request may close these issues.

feat: add React Router
2 participants
@martakam @hestro